From a05bdb3ee24674bd1df706f881296458f3339c6f Mon Sep 17 00:00:00 2001
From: Sean Buckley <sean.bck@gmail.com>
Date: Tue, 7 Sep 2021 23:13:03 -0400
Subject: [PATCH] fix vscode external terminal

---
 modules/desktop.nix    | 1 +
 modules/gnome.nix      | 5 +++++
 modules/i3/default.nix | 5 ++---
 3 files changed, 8 insertions(+), 3 deletions(-)

diff --git a/modules/desktop.nix b/modules/desktop.nix
index 6cb1154..99e977c 100644
--- a/modules/desktop.nix
+++ b/modules/desktop.nix
@@ -82,6 +82,7 @@ in
         "security.workspace.trust.banner" = "never";
         "security.workspace.trust.startupPrompt" = "never";
         "security.workspace.trust.untrustedFiles" = "newWindow";
+        "terminal.external.linuxExec" = "x-terminal-emulator";
         "terminal.integrated.fontFamily" = "Liberation Mono";
         "update.mode" = "none";
         "update.showReleaseNotes" = false;
diff --git a/modules/gnome.nix b/modules/gnome.nix
index b3c4cf0..54b9b32 100644
--- a/modules/gnome.nix
+++ b/modules/gnome.nix
@@ -26,6 +26,11 @@ in
       gnomeExtensions.sound-output-device-chooser
       numix-icon-theme
 
+      (runCommand "x-terminal-emulator" { } ''
+        mkdir -p $out/bin
+        ln -s ${gnome.gnome-terminal}/bin/gnome-terminal $out/bin/x-terminal-emulator
+      '')
+
       (writeShellScriptBin "red" ''
         x="$(gsettings get org.gnome.settings-daemon.plugins.color night-light-enabled)"
         [ "$x" = "true" ] && x=false || x=true
diff --git a/modules/i3/default.nix b/modules/i3/default.nix
index 3db5717..71561f2 100644
--- a/modules/i3/default.nix
+++ b/modules/i3/default.nix
@@ -84,10 +84,9 @@ in
         ln -sf /run/current-system/sw/share/icons/Yaru/cursor.theme $out/share/icons/default/index.theme
       '')
 
-      # VScode's default terminal is "truecolor"
-      (runCommand "truecolor-term-alias" { } ''
+      (runCommand "x-terminal-emulator" { } ''
         mkdir -p $out/bin
-        ln -s ${alacritty}/bin/alacritty $out/bin/truecolor
+        ln -s ${alacritty}/bin/alacritty $out/bin/x-terminal-emulator
       '')
     ];
   };